Ticket #34623

Y-modem is not compatible with existed implementations (e.g. Windows HyperTerm).

Date d'ouverture: 2014-11-21 00:00 Dernière mise à jour: 2015-02-02 13:10

Rapporteur:
Propriétaire:
(Aucun)
Type:
État:
Atteints
Composant:
Priorité:
5 - moyen
Sévérité:
5 - moyen
Résolution:
Aucun
Fichier:
4
Vote
Score: 0
No votes
0.0% (0/0)
0.0% (0/0)

Détails

Hi,

I tried to use TeraTerm to send files via y-modem protocol.

Unfortunately, it was not working.
I have checked the code and found several issues:
1) First packet size with filename, timestamp, etc. should be 128 bytes, not 1024.
2) The same for the last zero-filled packet.
3) Unnecessary read loop in YSendPacket should be removed as sometimes it prevents successful file upload.

I have attached a patch which fixes all described problems and cleanup YSendPacket a little.

Thanks,
Max

Ticket History (3/9 Histories)

2014-11-21 00:00 Updated by: mlukoshkov
  • New Ticket "Z-modem is not compatible with existed implementations (e.g. Windows HyperTerm)." created
2014-11-21 00:09 Updated by: mlukoshkov
  • Details Updated
  • Summary Updated
2014-11-25 23:25 Updated by: (del#1144)
Commentaire

Release process of Tera Term 4.85 is now in progress. Code is frozen now.

We are verifying patch.

2015-02-02 13:05 Updated by: (del#1144)
  • Ticket Close date is changed to 2015-02-02 13:05
  • État Update from Ouvert to Atteints
Commentaire

Hi,

We discussed about your patch and included some part of your patch.

https://sourceforge.jp/projects/ttssh2/scm/svn/commits/5771

following parts of patch was not applied:

1. block0 of file information does not 128 byte at all time. If file name is long, Tera Term sends STX packet (1024bytes)

2. deleted zero fill of OutPkt for resend packet.

2015-02-02 13:10 Updated by: (del#1144)
Commentaire

Attachment File List

  • ymodem.diff(18KB)
    • Patch for described error.
  • ymodem.c(18KB)
    • Hunk #10 FAILED at 610. Manually merged file.
  • ymodem.c(18KB)
    • Manually merge again.
  • ymodem.patch(11KB)
    • コード的な変更のみを抽出。r5731からの差分

Modifier

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Connexion